Skip to content

fix(aci): Gracefully handle missing actions in Alerts UI#112070

Merged
malwilley merged 3 commits intomasterfrom
malwilley/fix/gracefully-handle-missing-actions-in-alerts-ui
Apr 7, 2026
Merged

fix(aci): Gracefully handle missing actions in Alerts UI#112070
malwilley merged 3 commits intomasterfrom
malwilley/fix/gracefully-handle-missing-actions-in-alerts-ui

Conversation

@malwilley
Copy link
Copy Markdown
Member

Closes ISWF-2365

When an action is no longer available, we were previously rendering null, which made it impossible to get the alert in a working state for saving. This PR renders an item which can be removed with a helpful message telling the user to add a new action.

Before:

CleanShot 2026-04-01 at 16 40 18

After:

CleanShot 2026-04-01 at 16 40 00

@malwilley malwilley requested a review from a team as a code owner April 1, 2026 23:44
@linear-code
Copy link
Copy Markdown

linear-code bot commented Apr 1, 2026

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 1, 2026
Comment thread static/app/views/automations/components/actionNodeList.tsx Outdated
Comment thread static/app/views/automations/components/actionNodeList.tsx
Comment thread static/app/views/automations/components/actionNodeList.tsx Outdated
@malwilley malwilley marked this pull request as draft April 1, 2026 23:48
@malwilley malwilley marked this pull request as ready for review April 2, 2026 18:16
@malwilley malwilley requested a review from scttcper April 7, 2026 16:50
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 81a7f88. Configure here.

>
{actionLabel ?? t('Unknown integration')}
</AutomationBuilderRow>
);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API failure misreported as permanently unavailable actions

Medium Severity

When the useAvailableActionsQuery call fails (network error, 500, etc.), isLoadingActions becomes false and availableActions defaults to []. This causes getActionHandler to return undefined for every action, triggering the "no longer available" error message for all of them. Users could then be misled into deleting perfectly valid actions. The code checks isLoadingActions but not isError from the query, so a transient API failure is indistinguishable from a genuinely removed integration.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 81a7f88. Configure here.

@malwilley malwilley merged commit 9f85373 into master Apr 7, 2026
68 checks passed
@malwilley malwilley deleted the malwilley/fix/gracefully-handle-missing-actions-in-alerts-ui branch April 7, 2026 18:17
george-sentry pushed a commit that referenced this pull request Apr 9, 2026
When an action is no longer available, we were previously rendering
`null`, which made it impossible to get the alert in a working state for
saving. This PR renders an item which can be removed with a helpful
message telling the user to add a new action.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants